Repository navigation
src,fix: drop support for v0.2 and clean up contenttype - #67
Conversation
grant
left a comment
There was a problem hiding this comment.
Looks good besides the massive conflicts.
| @@ -91,21 +91,21 @@ These are the supported specifications by this version. | |||
|
|
|||
| | **Specifications** | v0.1 | v0.2 | v0.3 | **v1.0** | | |||
There was a problem hiding this comment.
We should just remove the column for v0.2. We already state we don't support 0.2 above.
|
@lance fix the conflicts, please. |
This commit removes support for the v0.2 specification. It also removes the `contenttype` attribute from the `CloudEvent` object. While the HTTP protocol binding specifies that in binary mode, the `datacontenttype` attribute should map to the HTTP Content-Type header, that doesn't mean that the `CloudEvent` object should have a `contenttype` property. Fixes: cloudevents#61 Fixes: cloudevents#66 Signed-off-by: Lance Ball <lball@redhat.com>
c3a16da to
9edd9cd
Compare
|
@fabiojose conflicts resolved |
|
Do we already have the semantic version? Is necessary to fill out the changelog? |
|
@lance something goes wrong with CI, can you check? https://travis-ci.org/github/cloudevents/sdk-javascript/builds/680741903 |
|
Here's the error: Something with the |
|
@fabiojose @grant This error is confusing. The coverage task didn't change with this commit. In fact, package.json didn't change at all. Hidden in the error message you pasted above is the real culprit.
Here are the first three lines of the codacy https://coverage.codacy.com/get.sh script that is run in order to publish the code coverage stats. 1 │ #!/usr/bin/env bash
2 │
3 │ set -e +o pipefailThe error indicates that the get.sh script provided an illegal option to the 1 │ #!/bin/bash
2 │
3 │ set -e +o pipefail
4 │
5 │ echo "hello!"Maybe the build was run on a corrupted container? I don't have permissions to re-run the build on Travis-CI. But can you try that first? |
This commit removes support for the v0.2 specification. It also removes the
contenttypeattribute from theCloudEventobject. While the HTTP protocolbinding specifies that in binary mode, the
datacontenttypeattribute shouldmap to the HTTP Content-Type header, that doesn't mean that the
CloudEventobject should have a
contenttypeproperty.Fixes: #61
Fixes: #66
Signed-off-by: Lance Ball lball@redhat.com